Slow down URL validation when adding a network or RPC #1241
Conversation
…n-adding-a-network-or-rpc
|
Here's the packed extension for this build: |
| @@ -277,6 +277,8 @@ const KNOWN_NETWORKS = { | |||
| ], | |||
| }; | |||
|
|
|||
| const parseURL = (url: string | undefined) => | |||
| url && (url.startsWith('http') ? url : `https://${url}`); | |||
There was a problem hiding this comment.
If a user enters localhost:8545 you'll autocomplete it to https://localhost:8545 which won't work so we have 2 options:
- Drop this and not add the prefix
- Add an exception for hosts
localhost&127.0.0.1where you only addhttp://
There was a problem hiding this comment.
I'm removing it for now so I can merge it
| @@ -277,6 +277,8 @@ const KNOWN_NETWORKS = { | |||
| ], | |||
| }; | |||
|
|
|||
| const parseURL = (url: string | undefined) => | |||
| url && (url.startsWith('http') ? url : `https://${url}`); | |||
There was a problem hiding this comment.
I'm removing it for now so I can merge it
…n-adding-a-network-or-rpc
|
Here's the packed extension for this build: |
…n-adding-a-network-or-rpc
|
Here's the packed extension for this build: |
…n-adding-a-network-or-rpc
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
brunobar79
deleted the
gregs/bx-1197-slow-down-url-validation-when-adding-a-network-or-rpc
branch
|
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
ups a bit the debounce delay and adds
https://to the url if neededScreen recordings / screenshots
What to test