Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce artifact noise #1628

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Jul 18, 2024

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • deprecate artifact comment links to reduce noise
  • leverage persistent artifacts on workflow runs instead

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c75e0a4a3c5e2f40a5b153424f4bea3516083917

@estebanmino
Copy link
Member

@DanielSinclair build step is failing here

@DanielSinclair DanielSinclair marked this pull request as draft July 31, 2024 05:20
Copy link

github-actions bot commented Aug 1, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-31a35603e5e19a2d85d42125f27849ce678d9dd3

@DanielSinclair
Copy link
Collaborator Author

I realized Workflow runs will already persit builds and e2e failure screenshots, so I think we can safely deprecate these additional PR comments all together
Screenshot 2024-08-01 at 5 50 35 PM

@DanielSinclair DanielSinclair marked this pull request as ready for review August 1, 2024 21:55
Copy link

github-actions bot commented Aug 1, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-3ca26436094c24c52947a97ba11400edcc33526f

Copy link

github-actions bot commented Aug 2, 2024

Here's the packed extension for this build:
rainbowbx-3ca26436094c24c52947a97ba11400edcc33526f

@DanielSinclair DanielSinclair added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Aug 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
Merged via the queue into master with commit c806127 Aug 8, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/reduce-artifacts branch August 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants