set max sell value on token selection (swaps) #1653
Conversation
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
DanielSinclair
changed the title
|
Here's the packed extension for this build: |
| @@ -454,8 +456,12 @@ export function Swap({ bridge = false }: { bridge?: boolean }) { | |||
| if (!assetToBuy) tokenToBuyInputRef.current?.openDropdown(); | |||
| setAssetToSellInputValue(''); | |||
| setAssetToBuyInputValue(''); | |||
| if (asset) { | |||
| setHasRequestedMaxValueAssetToSell(true); | |||
There was a problem hiding this comment.
instead of a flag that triggers the useEffect can't we just put setAssetToSellMaxValue(); here?
There was a problem hiding this comment.
Yeah i tried doing that. One problem i saw is some funky state behaviours since you need to set the asset first before calling setAssetToSellMaxValue. Here is an example of what we do in other places https://github.com/rainbow-me/browser-extension/blob/master/src/entries/popup/pages/swap/index.tsx#L527-L531
There was a problem hiding this comment.
ah I see 🫠 hate it but seems like only refactoring everything to do that
magiziz
force-pushed
the
@mago/token-sell-max-input
branch
from
2b9da55
to
1e9eb55
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Chrome swap e2e test seems to fail, but works locally. Going to see what's going on. 
|
greg-schrammel
force-pushed
the
@mago/token-sell-max-input
branch
from
ff19091
to
e579ace
Compare
magiziz
force-pushed
the
@mago/token-sell-max-input
branch
from
e579ace
to
4c4ef8a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fixes BX-1566
Figma link (if any):
What changed (plus any additional context for devs)
Once sell token has been selected we set max input value.
Screen recordings / screenshots
token-to-sell-max-value.mov
What to test
Go to swaps, select a token and make sure the input value is set to max.