hidden assets for magic menu (CmdK) #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magiziz
requested review from
DanielSinclair,
estebanmino,
derHowie and
BrodyHughes
chore: more tweaks
magiziz
force-pushed
the
@mago/filter-hide-token-nft
branch
from
c05a2c6
to
467d0a7
Compare
|
Hide/unhide functionality works, but if you pull up the cmd-k menu while you're on the assets list then return after hiding a token, the list's rendering seems to be messed up when you scroll. Sometimes there are blank gaps and sometimes there are overlaps. I'm guessing this means the keys are getting messed up or the new list needs a |
|
@magiziz Can you have a look at the issue Chris mentioned? Can get this merged this week |
|
@derHowie is this ready for review? |
yes |
estebanmino
approved these changes
Sep 9, 2024
BrodyHughes
reviewed
Sep 9, 2024
derHowie
approved these changes
Oct 3, 2024
|
Merging per Chris's recommendation about the token cell update issue. Created a follow-up ticket for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1377
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
BX-1377.mov
What to test
Make sure hide and unhide actions work with tokens and nfts in CmdK menu.