Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrap / Unwrap #1675

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix Wrap / Unwrap #1675

merged 2 commits into from
Aug 21, 2024

Conversation

brunobar79
Copy link
Member

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • Bump sdk with correct types for wrap / unwrap quotes
  • Fix wrapping / unwrapping
  • Hide price impact for wrapping / unwrapping

Screen recordings / screenshots

Screen.Recording.2024-08-21.at.11.34.12.AM.mov

What to test

Wrapping / Unwrapping

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rainbow-me/swaps@0.24.0 environment, eval, network 0 789 kB brunobar79

🚮 Removed packages: npm/@rainbow-me/swaps@0.23.0

View full report↗︎

@brunobar79 brunobar79 added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit 394240c Aug 21, 2024
14 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-wrap-unwrap branch August 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants