Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger stax, flex upgrade #1707

Merged
merged 1 commit into from
Sep 23, 2024
Merged

ledger stax, flex upgrade #1707

merged 1 commit into from
Sep 23, 2024

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Sep 20, 2024

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • upgrades for Ledger Stax and Flex
  • removed unnecessary sticky internal Ledger SDK dependencies

Screen recordings / screenshots

What to test

  • Ledger Nano regression, Ledger Stax or Flex pairing + signing

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/cryptoassets@13.4.0 None 0 62.8 MB ldg-github-ci
npm/@ledgerhq/devices@8.4.3 None 0 222 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/domain-service@1.2.4 None 0 142 kB ldg-github-ci
npm/@ledgerhq/errors@6.19.0 None 0 207 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/evm-tools@1.2.1 None 0 133 kB ldg-github-ci
npm/@ledgerhq/hw-app-eth@6.38.1 None 0 2.17 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/hw-transport-mocker@6.29.3 None 0 107 kB ldg-github-ci
npm/@ledgerhq/hw-transport-webhid@6.29.3 None 0 75.2 kB ldg-github-ci
npm/@ledgerhq/hw-transport@6.31.3 None 0 132 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/live-env@2.3.0 None 0 266 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/types-live@6.51.0 None 0 374 kB ldg-github-ci

🚮 Removed packages: npm/@ledgerhq/cryptoassets@13.3.0, npm/@ledgerhq/devices@8.4.2, npm/@ledgerhq/domain-service@1.2.3, npm/@ledgerhq/errors@6.18.0, npm/@ledgerhq/evm-tools@1.2.0, npm/@ledgerhq/hw-app-eth@6.38.0, npm/@ledgerhq/hw-transport-mocker@6.29.2, npm/@ledgerhq/hw-transport-webhid@6.28.2, npm/@ledgerhq/hw-transport@6.31.2, npm/@ledgerhq/live-env@2.2.0, npm/@ledgerhq/live-network@1.4.0, npm/@ledgerhq/live-promise@0.1.0, npm/@ledgerhq/types-live@6.50.0

View full report↗︎

@DanielSinclair DanielSinclair changed the title ledger stax upgrade ledger stax, flex upgrade Sep 20, 2024
Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested swaps / sends / imports. also ran e2e locally and seems good!

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunobar79 brunobar79 merged commit 159e491 into master Sep 23, 2024
14 checks passed
@brunobar79 brunobar79 deleted the @daniel/ledger-upgrade-3 branch September 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants