Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal networks filtering #1715

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

DanielSinclair
Copy link
Collaborator

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • added internal type to BackendNetwork type and ingestion query
  • filtering out internal networks in prod, showing for INTERNAL_BUILD or IS_DEV

Screen recordings / screenshots

Screenshot 2024-09-25 at 12 25 10 AM Screenshot 2024-09-25 at 12 24 46 AM

What to test

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@DanielSinclair DanielSinclair merged commit 6516a21 into master Sep 25, 2024
14 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/internal-networks branch September 25, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants