-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend user native asset #1717
extend user native asset #1717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
// Prefetch function for Token Price | ||
export async function prefetchExternalToken({ | ||
address, | ||
chainId, | ||
currency, | ||
}: ExternalTokenArgs) { | ||
await queryClient.prefetchQuery({ | ||
queryKey: externalTokenQueryKey({ address, chainId, currency }), | ||
queryFn: externalTokenQueryFunction, | ||
staleTime: EXTERNAL_TOKEN_STALE_TIME, | ||
gcTime: EXTERNAL_TOKEN_CACHE_TIME, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we'll end up using this prefetch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a copy paste from app, i can remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes BX-1635
Figma link (if any):
using metadata external token query to get native assets for all chains as described in ticket
now we have two different hooks for this:
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test