Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It looks not as nice as the demo #3

Closed
kaiyulee opened this issue Jul 1, 2016 · 13 comments
Closed

It looks not as nice as the demo #3

kaiyulee opened this issue Jul 1, 2016 · 13 comments
Assignees

Comments

@kaiyulee
Copy link

kaiyulee commented Jul 1, 2016

look:

iTerm2 or terminal on Mac

screenshot: http://o9m8gqxa3.bkt.clouddn.com/scone.png

@rakr
Copy link
Owner

rakr commented Jul 1, 2016

Would you mind providing the following information:

  • Terminal you are using and the version
  • Vim or NeoVim and the version
  • Are you using tmux?

@rakr
Copy link
Owner

rakr commented Jul 1, 2016

Actually, i think I know the reason. Italic is not supported by your terminal. Will post a fix soon that would require a configuration setting.

@rakr rakr self-assigned this Jul 1, 2016
rakr added a commit that referenced this issue Jul 1, 2016
@rakr
Copy link
Owner

rakr commented Jul 1, 2016

@kaiyulee, thanks for opening this issue. It seems like your terminal does not support italic,

This update should fix your problem. Please make sure to have the following lines in your ~/.vimrc

set background=dark
set g:one_allow_italics=1
colorscheme one

@rakr rakr added fixed and removed In Progress labels Jul 1, 2016
@kaiyulee
Copy link
Author

kaiyulee commented Jul 1, 2016

iTerm2 Build 3.0.1 + vim 7.4.1345, iTerm2 has the tmux integration.

And still has the clear & beautiful problem.

It seems like not the plugin's problem. I had tried the material colorscheme mounthes before, It also has the display issue - it not as clear & beautiful as yours, but both the material and the one display well with MacVim. So the key maybe is the vim.

@rakr
Copy link
Owner

rakr commented Jul 1, 2016

Sorry to hear that, to support True Colors in Terminal you would need

@rakr rakr closed this as completed Jul 1, 2016
@rakr
Copy link
Owner

rakr commented Jul 1, 2016

Your version of Vim does not support true colours. Try to upgrade it.

@kepbod
Copy link

kepbod commented Oct 28, 2016

It only works for vim, but not neovim.
My information:

  • Iterm2 Build 3.0.10
  • Vim 8.0
  • Neovim 0.1.5

@rakr
Copy link
Owner

rakr commented Oct 28, 2016

@kepbod, Sorry but I can't help you fix this issue on Neovim if you don't provide more information, your ~/.vimrc or /.config/nvim/init.vim would be a great start.
also don't forget that you must set termguicolors for this to work.

@kepbod
Copy link

kepbod commented Oct 29, 2016

Sorry that I forgot to attach my configuration.
My ~/.config/nvim/init.vim is https://github.com/kepbod/ivim/blob/master/vimrc_nvim, and I set iterm using https://gist.github.com/kepbod/2ea79ee2ada4c22591dc043c1ed4364c.
Thanks a lot for your helps.

@rakr
Copy link
Owner

rakr commented Oct 29, 2016

try removing the set t_Co line

@kepbod
Copy link

kepbod commented Oct 29, 2016

It did not work after I removed the set t_Co line.

@kepbod
Copy link

kepbod commented Oct 30, 2016

I fixed it by add below gist in .vimrc according to https://www.reddit.com/r/vim/comments/24g8r8/italics_in_terminal_vim_and_tmux/?st=iux2r3zl&sh=87e1d8bf.

set t_ZH=^[[3m
set t_ZR=^[[23m

But I doesn't know why.

@rakr rakr added fixed and removed fixed labels Jan 25, 2017
@b-fuze
Copy link

b-fuze commented Mar 30, 2023

If kepbod's snippet above doesn't work for you like it didn't for me, then it's likely because it requires actually typing the Esc character—which won't look as nice in other editors or display properly in a browser. A nicer way that looks the same across editors and in a browser is:

let &t_ZH = "\<Esc>[3m"
let &t_ZR = "\<Esc>[23m"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants