Adapt update-rancher-charts to support an empty release.yaml file #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
approved these changes
Jul 7, 2023
Danil-Grigorev
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a PR against rancher/charts while releasing a new version of the operator, if
REPLACE=true(e.g. bumping rc versions) andrelease.yamlin the charts repository is empty (this file is periodically cleaned), the workflow will not update the release file with the updated versions.Fix
This change adds an extra validation when
REPLACE=true, and only tries to substitute versions ifrelease.yamlalready contains an entry forrancher-eks-operator. If it is not, it will populate the file treating it as empty.Followed the style used in Fleet for the validation.