Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document EKSClusterConfig API #225

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Document EKSClusterConfig API #225

merged 1 commit into from
Sep 26, 2023

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Aug 26, 2023

Issue: #203

@mjura mjura requested a review from a team as a code owner August 26, 2023 10:33
@mjura mjura mentioned this pull request Aug 26, 2023
Closed
1 task
richardcase
richardcase reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjura 👍 Just a few minor comments.

pkg/apis/eks.cattle.io/v1/types.go Show resolved Hide resolved
pkg/apis/eks.cattle.io/v1/types.go Show resolved Hide resolved
@mjura mjura force-pushed the api-docs branch 2 times, most recently from 4601c84 to 11e3976 Compare September 18, 2023 07:41
richardcase
richardcase reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjura - are you sure that everything marked as "required" is actually required? The reason i ask is that a lof of the types are pointers which can denote something being optional.

pkg/apis/eks.cattle.io/v1/types.go Show resolved Hide resolved
@mjura
Copy link
Contributor Author

mjura commented Sep 25, 2023

@mjura - are you sure that everything marked as "required" is actually required? The reason i ask is that a lof of the types are pointers which can denote something being optional.

I think that pointers should be verified, but let's stay consistent with Kubebuilder markers

@mjura mjura merged commit 2df004f into rancher:master Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salasberryfin salasberryfin salasberryfin approved these changes

@richardcase richardcase Awaiting requested review from richardcase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjura @richardcase @salasberryfin