Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] Sync go.mod with release-v2.8 #247

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[2.7] Sync go.mod with release-v2.8 #247

merged 1 commit into from
Sep 4, 2023

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Sep 4, 2023 •
edited
Loading

Backport go.mod from v2.8, we have to downgrade Kubernetes version,
otherwise it will break rancher integration.

@mjura mjura requested a review from a team as a code owner September 4, 2023 11:36
furkatgofurov7
furkatgofurov7 requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjura can you please add a PR description with information, i.e what issue this PR is solving / why we need it? Otherwise, sometimes it is hard to guess what are we trying with these kinds of PRs

@furkatgofurov7
Copy link
Contributor

Q: why we should sync v2.7 go mod with v2.8, as I think they are different versions of operators tracking corresponding versions of Rancher and they should have a diff between them, no?

@mjura
Copy link
Contributor Author

mjura commented Sep 4, 2023

Q: why we should sync v2.7 go mod with v2.8, as I think they are different versions of operators tracking corresponding versions of Rancher and they should have a diff between them, no?

Yes, I agree. It is backport from v2.8 to v2.7. Added comment to commit message

@mjura
Sync go.mod with release-v2.8
ad81bf5 
Backport go.mod from v2.8, we have to downgrade Kubernetes version,
otherwise it will break rancher integration.
furkatgofurov7
furkatgofurov7 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how these deps got bumped (we have ignore for it in dependabot) to these versions though the changes in this PR makes sense to me.
@mjura probably we could also decide to ignore aws-sdk-go bumps in the dependabot configuration, if it break the stuff and we want to do it manually.

@mjura mjura merged commit 79f8943 into rancher:release-v2.7 Sep 4, 2023
7 checks passed
@salasberryfin
Copy link
Contributor

Not sure how these deps got bumped (we have ignore for it in dependabot) to these versions though the change makes sense to me. @mjura probably we could also decide to ignore aws-sdk-go bumps in the dependabot configuration, if it break the stuff and we want to do it manually.

I also think we should consider ignoring bumps on aws-sdk-go. I remember @richardcase troubleshooting and fixing a bug caused by an update to aws-sdk-go that broke IAM authentication rancher/rancher#41716 (comment).

@furkatgofurov7
Copy link
Contributor

rancher/rancher#41716 (comment)

or have a CI to test it when the bump PR is opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salasberryfin salasberryfin salasberryfin approved these changes

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjura @furkatgofurov7 @salasberryfin @Danil-Grigorev