Publish custom rancher chart with operator #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just nitpicking a bit, sorry. LGTM, though. I understand this is intended to publish updates to current Rancher version (in this case 2.8) and back-ports to other currently maintained versions (as we've been doing lately) will be done "manually". Is this correct? |
|
Looks like this needs a manual rebase. |
alexander-demicev
force-pushed
the
newworkflows
branch
from
8048297
to
0379f57
Compare
|
Sorry, I know I'm being very picky but, can we update the typos in the name of the operator ( |
richardcase
reviewed
Oct 10, 2023
alexander-demicev
force-pushed
the
newworkflows
branch
from
0379f57
to
c733e71
Compare
salasberryfin
approved these changes
Oct 10, 2023
| default: "dev-v2.7" | ||
| prev_eks_operator: | ||
| default: "dev-v2.8" | ||
| prev_aks_operator: |
There was a problem hiding this comment.
Suggested change
| prev_aks_operator: | |
| prev_eks_operator: |
| description: "Previous EKS operator version (e.g. 1.1.0-rc2)" | ||
| required: true | ||
| default: "" | ||
| new_eks_operator: | ||
| new_aks_operator: |
There was a problem hiding this comment.
Suggested change
| new_aks_operator: | |
| new_eks_operator: |
Comment on lines
36
to
37
| prev_operator_version: ${{ github.event.inputs.prev_aks_operator }} | ||
| new_operator_version: ${{ github.event.inputs.new_aks_operator }} |
There was a problem hiding this comment.
Suggested change
| prev_operator_version: ${{ github.event.inputs.prev_aks_operator }} | |
| new_operator_version: ${{ github.event.inputs.new_aks_operator }} | |
| prev_operator_version: ${{ github.event.inputs.prev_eks_operator }} | |
| new_operator_version: ${{ github.event.inputs.new_eks_operator }} |
| new_eks: | ||
| description: "New EKS operator version (e.g. 1.1.0-rc2), don't include the 'v'" | ||
| description: "New AKS operator version (e.g. 1.1.0-rc2), don't include the 'v'" |
There was a problem hiding this comment.
Suggested change
| description: "New AKS operator version (e.g. 1.1.0-rc2), don't include the 'v'" | |
| description: "New EKS operator version (e.g. 1.1.0-rc2), don't include the 'v'" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish custom rancher chart with operator. Currently, there is no way to test changes in operator CRDs before tagging a release and merging an update PR in rancher/rancher. This PR adds a step to the nightly workflow to update rancher dependencies and build a chart based on that.
Fixes: rancher/highlander#20
Fixes: rancher/highlander#18
Fixes: rancher/highlander#21