-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of ninja support #3508
Conversation
Fixed the CLI build in 26bdd18. |
94b07ed
to
b03f08c
Compare
d82f505
to
676bf26
Compare
Targets to include:
|
I think I got the most important targets supported now (see list in comment above). @randombit Any additional targets we want to support? There is one issue remaining though: When using absolute paths on Windows, e.g., as in the Analysis (sanitizer, msvc, windows-2022, ninja) job, Ninja treats the colon as the end of output separator in the build statement:
Colons in Ninja can be escaped as |
Added bogo_shim, fuzzers and examples targets as well. Also updated the docs and removed support for JOM. |
I smoke tested this on macOS and it seems to work nicely. Only thing missing is the Windows sanitizer CI job:
On my Mac the build occasionally spits out lines like below. I can't really place that off the top of my head.
|
Yeah I developed this on macOS and then cross-tested on Windows. |
@securitykernel I can't review/approve my own PR - can you open a new PR? |
Do we still need a resolution to the pathname escaping? Can we use quotes instead? Ideally we don't have to build ninja-specific handling into the template language |
Nope, tested and is not sufficient. What fixes it only is using the escape character |
This is sufficient to build the static library, but there is a lot more work to be done here. Many missing targets, also I think there is something wrong with the dependencies since ninja tries to link the cli before the library has finished.
@securitykernel @reneme or whoever, feel free to either push onto this branch or take it as a base for a new PR. I probably am not going to do any more work towards this, with the exception that if there are bugs/missing features in the template language that are needed I would take that part.
#3495