SPHINCS+ #3533
Closed
SPHINCS+ #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed you defined params for Haraka as well. If you plan to support this (I am ambivalent either way on this point) please create a distinct PR for adding it. |
It's not quite clear whether we'll add Haraka. Currently the parameters were added for completeness. Certainly, support for Haraka won't come in this first PR. |
- add mgf1 and shake as required for sphincsplus Later at least shake should probably be optional - remove thread_pool.h import - update comment
Co-Authored-By: Amos Treiber<amos.treiber@rohde-schwarz.com> Co-Authored-By: Rene Meusel<rene.meusel@rohde-schwarz.com>
reneme
commented
May 8, 2023
Comment on lines
+21
to
+26
| auto sha256 = [](const Botan::Sphincs_Address& adrs) | ||
| { | ||
| auto h = Botan::HashFunction::create_or_throw("SHA-256"); | ||
| adrs.apply_to_hash(*h); | ||
| return h->final_stdvec(); | ||
| }; |
There was a problem hiding this comment.
Add test for apply_to_hash_compressed()
reneme
commented
May 8, 2023
Comment on lines
+81
to
+83
| if(result.tests_failed() > 0){ | ||
| int x = 0; // Dummy | ||
| } |
|
Closing in favor of #3549. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3099
This is a huge mess at the moment... no need to look deeper into it at this point.
TODO
Implementation Milestones
That's a rough collection of implementation work packages. We'll keep it updated as things progress.