Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Curve25519 to X25519 #4012

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Rename Curve25519 to X25519 #4012

merged 2 commits into from
Apr 17, 2024

Conversation

randombit
Copy link
Owner

No description provided.

@randombit randombit requested a review from reneme April 12, 2024 22:01
@randombit
Rename Curve25519 to X25519
a7d0ae6 
This better matches modern usage.

The old name is still accepted as an input (OID::from_name,
create_private_key, etc)
@randombit
Remove X25519 scalar mult test
81db0c6 
This was equivalent in operation to the standard X25519 key agreement
test, just in a different format. Move the test data there.
@coveralls
Copy link

Coverage Status

coverage: 92.028% (-0.004%) from 92.032%
when pulling 81db0c6 on jack/just-x25519
into c479ebb on master.

reneme
reneme approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Consistency with X448 restored, I guess. :)

Regarding semver: Names of modules aren't covered in the semver guarantees?
This would now cause issues across versions in 3.x:

./configure.py --minimized-build --enable-modules=curve25519

... not sure whether this justifies a 'module alias mechanism' of some sort, though.
Perhaps its enough to leave curve25519 as a module, mark it as "deprecated" (#3910), and let it contain the deprecated curve25519.h?

@randombit
Copy link
Owner Author

No - building the library (module names, configure.py options, module policy details) has never been covered by SemVer. Only using the resulting binary. This has "always" been the case and I know there have been similar breaks in the past though I don't recall the details off the top of my head. The written SemVer policy should make all this clear though.

@randombit randombit merged commit d1ba2fd into master Apr 17, 2024
43 checks passed
@randombit randombit deleted the jack/just-x25519 branch April 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randombit @coveralls @reneme