New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numbered notebook folders and edited readme #212

Open

taureandyernv wants to merge 1 commit into branch-0.12 from renumbering

Contributor

taureandyernv commented Oct 18, 2019

Numbered learning notebook folders so that

they are on top of all the other folders
they are in order

Changed readme to suit

Suggestion by @miguelangel . Please review and let me know what you think!


          numbered notebook folders and edited readme

0da83ad

taureandyernv requested review from cjnolet, randerzander, miguelusque and BradReesWork

October 18, 2019 05:51

Contributor

miguelusque commented Oct 18, 2019

Hi Tauren,

Please, find below a few comments:

I think the notebooks under the following folder should also be renumbered.
https://github.com/rapidsai/notebooks-contrib/tree/renumbering/1_getting_started_notebooks/basics
It seems that notebook number 05 it is missing at https://github.com/rapidsai/notebooks-contrib/tree/renumbering/1_getting_started_notebooks/intro_tutorials
I'd say notebooks 09 and 10 should be renamed to 03, 04, at https://github.com/rapidsai/notebooks-contrib/tree/renumbering/1_getting_started_notebooks/intro_tutorials

Hope it helps

Regards
Miguel

taureandyernv mentioned this pull request

number notebook folders for easier starting #211

Closed

mike-wendt changed the base branch from master to branch-0.12

December 11, 2019 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet