force use of unsigned dtype as input to cp.bincount

seems to avoid bug with larger signed integer ranges and CUDA 12.x
rapidsai · Jul 3, 2023 · 3cc9df6 · 3cc9df6
1 parent 81bb2f2
commit 3cc9df6
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/python/cucim/src/cucim/skimage/exposure/exposure.py b/python/cucim/src/cucim/skimage/exposure/exposure.py
@@ -72,8 +72,14 @@ def _bincount_histogram(image, source_range, bin_centers=None):
     """
     if bin_centers is None:
         bin_centers = _bincount_histogram_centers(image, source_range)
-    image_min, image_max = bin_centers[0], bin_centers[-1]
-    image = _offset_array(image, image_min.item(), image_max.item())  # synchronize  # noqa
+    image_min, image_max = bin_centers[0].item(), bin_centers[-1].item()
+    image = _offset_array(image, image_min, image_max)  # synchronize  # noqa
+
+    # Casting back to unsigned dtype seems necessary to avoid incorrect
+    # results for larger integer ranges with CUDA 12.x.
+    unsigned_dtype_char = image.dtype.char.upper()
+    image = image.astype(unsigned_dtype_char, copy=False)
+
     hist = cp.bincount(
         image.ravel(), minlength=image_max - min(image_min, 0) + 1
     )