[BUG] some thresholding functions require scikit-image>=0.19

[grlee77]

Describe the bug

Changes made in #276 break use of some thresholding functions if the user does not have scikit-image >= 0.19. We should either bump our minimum requirement to 0.19 or provide a fallback.

Steps/Code to reproduce bug
many test failures are seen for cucim/skimage/filters/tests/test_thresholding.py

Expected behavior
all tests should pass

Environment details (please complete the following information):
cuCIM branch 22.08

[jakirkham]

It looks like we didn't bump this dependency. Should we be doing this? Also is this only test related or would users see this in workflows?

cucim/conda/recipes/cucim/meta.yaml

Line 35 in e155e32

- scikit-image >=0.18.1,<0.20.0a0

[grlee77]

The functions failing with 0.18 are;

• threshold_multiotsu (hist kwarg isn't present in 0.18.x)
• threshold_minimum (max_iter was deprecated in 0.19 and we use the new max_num_iter which wasn't present in 0.18)
• try_all_threshold (fails due to the same threshold_minimum failure)

All will work if the user upgrades to >=0.19.

[grlee77]

This commit where we deferred some computations to scikit-image and removed duplicate code is what lead to the issue.