-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run script for local builds #12
Conversation
Hi @raydouglass Since we didn't tag v0.19.0 yet and VERSION files in branch-0.20 are still referring to 0.19.0, would it make sense to fast-forward branch-0.19 branch to branch-0.20 instead of creating a PR with the same commits to branch-0.19? If branch-0.19 is not available for fast-forwarding, I can create a PR with the duplicate commits in branch-0.20 for branch-0.19. |
I see some build error because python build is using the existing libcucim conda package but libcucim code in C++ is also changed in the PR. Wonder if I need to push PRs for libcucim(core lib code) and cucim (pybind11&python code) separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
c3559c8
to
05d4af6
Compare
It seems that it always using libcucim from nightly build
@ajschmidt8 Do you have any idea on that? How could we handle the situation? |
05d4af6
to
9bc2618
Compare
d3378c0
to
3948e9b
Compare
3948e9b
to
cd3ae09
Compare
I found that libcucim's built package is available at This PR is passing now. @quasiben, please help review the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gigony I'll port these changes back to 0.19 after being merged
run
script to download GDS from public package (cufile.h is needed to build it locally)yasm
which is needed for building libjpeg-turbov0.18.3
and update the release date of v0.19.0 to 4/19/2021Verified with a fresh system that https://github.com/rapidsai/cucim/blob/branch-0.20/CONTRIBUTING.md#script-to-build-cucim-from-source is working. (Previously it didn't work due to
yasm
dependency).