Fix thread contention in Cache #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
force-pushed
the
fix_thread_contention
branch
from
3693c0f
to
e8b3722
Compare
gigony
changed the title
gigony
changed the title
gigony
force-pushed
the
fix_thread_contention
branch
from
e8b3722
to
ef394f3
Compare
|
PR ( #141 ) is in. So this is ready for rebasing |
When multiple threads are used, it can cause thread contentions so performance can be degraded. This patch fixes the issue by using a hash value for the index.
gigony
force-pushed
the
fix_thread_contention
branch
from
ef394f3
to
1c03a76
Compare
gigony
changed the title
@jakirkham |
Merged
jakirkham
approved these changes
Nov 29, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to rebase once #141 is merged.
When multiple threads are used, it can cause thread contentions so
performance can be degraded.
It is found that the performance degradation is due to
lock()method in cuCIM's cache implementation.This patch fixes the issue by using a hash value for the index of the mutex pool.
Also, the default mutex pool size is increased from 11117 to 100003.
After Fix
Note:: experiment on JPEG-compressed SVS had an incorrect configuration (start location and patch size was specified as (128,256) instead of (120, 240)) so updated it in both documents and Google Spreadsheet.
Close #146