Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate correct channel names for RGBA image #294

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Populate correct channel names for RGBA image #294

merged 1 commit into from
Jun 1, 2022

Conversation

gigony
Copy link
Contributor

@gigony gigony commented May 25, 2022

Fix a segmentation fault raised when loading RGBA image and accessing metadata.

Addresses #262
Signed-off-by: Gigon Bae gbae@nvidia.com

@gigony gigony added bug Something isn't working non-breaking Introduces a non-breaking change labels May 25, 2022
@gigony gigony added this to the v22.06.00 milestone May 25, 2022
@gigony gigony self-assigned this May 25, 2022
@gigony gigony requested review from a team as code owners May 25, 2022 22:34
grlee77
grlee77 requested changes May 26, 2022
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/suggestion, but otherwise this looks good.

I appreciate the new test case. Do you think we should also have a version with a 2D grayscale image?

cpp/plugins/cucim.kit.cuslide/src/cuslide/cuslide.cpp Show resolved Hide resolved
@gigony
Populate correct channel names for RGBA image
6d965eb 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ccfdb83 into rapidsai:branch-22.06 Jun 1, 2022
@jakirkham
Copy link
Member

Thanks Gigon! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grlee77 grlee77 grlee77 approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@gigony gigony

Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
v22.06.00
Development

Successfully merging this pull request may close these issues.
3 participants
@gigony @jakirkham @grlee77