Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.rst #314

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Update index.rst #314

merged 2 commits into from
Jul 11, 2022

Conversation

HesAnEasyCoder
Copy link
Collaborator

No description provided.

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

HesAnEasyCoder
HesAnEasyCoder commented Jun 15, 2022
View reviewed changes
Copy link
Collaborator Author

@HesAnEasyCoder HesAnEasyCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporates cuCIM definition, workflow integration, applicable file formats, and download links

@HesAnEasyCoder HesAnEasyCoder added doc Improvements or additions to documentation breaking Introduces a breaking change labels Jun 15, 2022
HesAnEasyCoder
HesAnEasyCoder commented Jun 15, 2022
View reviewed changes
Copy link
Collaborator Author

@HesAnEasyCoder HesAnEasyCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments. I just incorporated references.

@jakirkham
Copy link
Member

Would it be alright if we move this to 22.08?

@HesAnEasyCoder
Copy link
Collaborator Author

HesAnEasyCoder commented Jun 17, 2022 via email

@gigony gigony added non-breaking Introduces a non-breaking change and removed breaking Introduces a breaking change labels Jun 21, 2022
@gigony gigony changed the base branch from branch-22.06 to branch-22.08 June 21, 2022 05:29
HesAnEasyCoder and others added 2 commits June 20, 2022 22:34
@HesAnEasyCoder @gigony
Update index.rst
4b82102
@gigony
Revise index.rst
f2ae080 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
gigony
gigony approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@gigony gigony left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HesAnEasyCoder !

Revised some text to match to reStructuredText format.
(Used https://pandoc.org/try/?from=markdown&to=rst&standalone=0 )

Looks good to me!

@grlee77 grlee77 added this to the v22.08.00 milestone Jun 28, 2022
@gigony
Copy link
Contributor

gigony commented Jun 28, 2022

We could link https://nbviewer.org/github/rapidsai/cucim/blob/branch-22.08/notebooks/Welcome.ipynb link in the doc.

@HesAnEasyCoder
Copy link
Collaborator Author

HesAnEasyCoder commented Jul 8, 2022 via email

@jakirkham
Copy link
Member

Users will still be able to read the updated docs before the release

https://docs.rapids.ai/api/cucim/nightly/

@jakirkham
Copy link
Member

@gpucibot merge

@raydouglass raydouglass merged commit 0341bb3 into branch-22.08 Jul 11, 2022
@raydouglass raydouglass deleted the HesAnEasyCoder-patch-1 branch July 11, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@gigony gigony gigony approved these changes

Assignees

@gigony gigony

Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
v22.08.00
Development

Successfully merging this pull request may close these issues.
7 participants
@HesAnEasyCoder @GPUtester @jakirkham @gigony @quasiben @raydouglass @grlee77