parameterization of filters and features benchmarks (v2)
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parametrizing filters benchmarks
Disabling CPU runs
avoid use of deprecated multichannel argument avoid use of deprecated selem argument
grlee77
added
improvement
jakirkham
approved these changes
Jul 26, 2022
|
Looks like there are some conflicts. Could you please take a look at these @grlee77? 🙂 |
…refactor [gpuci skip]
jakirkham
approved these changes
Jul 26, 2022
|
@gpucibot merge |
Resolved. should be good to go now. No point to wait on CI as it doesn't run these benchmarks. |
|
Yeah it won't merge until CI passes. So we just need to wait unfortunately. On the bright side it should merge as soon as CI passes |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
This PR expands the approach of #322 to the remaining `cucim.skimage` benchmarks as well This PR is built on top of a few other open benchmarking PRs, so please review and merge those first: (#322, #323, #290) Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/aasthajh Approvers: - https://github.com/jakirkham URL: #324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #278 for branch-22.08 with minor additional fixes. I have tested this locally and it seems to be operating as expected.