Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: avoid use of deprecated pandas API #339

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 26, 2022

This is an update of the previously-approved #290 from branch-22.06 to branch-22.08

The append method of DataFrame is deprecated since pandas 1.4.0
The recommendation is to use pandas.concat instead:
https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append
@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 26, 2022
@grlee77 grlee77 added this to the v22.08.00 milestone Jul 26, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Jul 26, 2022

@gbae, you previously approved this in #290. Can you do that again here so we can merge this for 22.08?

Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. re-approving :)

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e5006ff into rapidsai:branch-22.08 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants