Add missing imports of euler_number and perimeter_crofton #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public functions should be imported from top-level skimage.measure
grlee77
added
bug
jakirkham
approved these changes
Aug 5, 2022
|
@gpucibot merge |
|
Currently users could only obtain these only via import from a private submodule: from cucim.skimage.measure._regionprops import euler_number, perimeter_croftonwhile the fix here makes it available via from cucim.skimage.measure import euler_number, perimeter_crofton |
|
Thanks Greg! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions had been implemented, but were missing from the
__init__.pyinskimage.measure. This was not caught because the test cases had imported them from the private submodule!