improved implementation of ridge filters (bug fixes and reduced memory footprint) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: scikit-image/scikit-image#6149 scikit-image/scikit-image#6440 scikit-image/scikit-image#6446 scikit-image/scikit-image#6509 These fix various bugs, simplify the implementaiton and reduce the memory footprint
grlee77
added
breaking
grlee77
force-pushed
the
skimage020-update-ridge-filters
branch
from
5959345
to
ca369e8
Compare
gigony
approved these changes
Nov 16, 2022
|
@gpucibot merge |
|
Merged this one so I can rebase #434 on top of it to look at one failing test case in the ridge filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #419
A large overhaul of the ridge filters, addressing inaccuracies and errors has been implemented for scikit-image 0.20. This PR ports the same changes to these functions to cuCIM.
upstream PRs:
These fix various bugs, simplify the implementation and reduce the memory footprint