pin to cmake !3.25.0 on CI to avoid bug with CUDA+conda during build #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
bug
|
cc @robertmaynard (for awareness) |
grlee77
changed the title
grlee77
changed the title
ajschmidt8
reviewed
Nov 17, 2022
There was a problem hiding this comment.
can we update these pinnings to match https://github.com/rapidsai/cudf/pull/12188/files?
That pinning is a little more forgiving than a max version pin.
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
ajschmidt8
approved these changes
Nov 18, 2022
|
Thanks @ajschmidt8, I applied the suggestions and it should be ready to merge now |
|
@gpucibot merge |
|
Thank you both! 🙏 |
grlee77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.25 was released today and seems to have broken the CI builds. Trying to pin the version here to see if it resolves the issue.
attn: @jakirkham