Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up install issues encountered on CI #45

Closed
wants to merge 13 commits into from

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 27, 2021

Includes PR ( #41 ) and PR ( #43 ) Dropped as these are now in branch-21.06

Also makes some fixes to hopefully address the install issues we are seeing on CI.

@jakirkham jakirkham requested review from a team as code owners May 27, 2021 16:53
@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change labels May 27, 2021
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Do you know why it is still failing in CI/CD?

@quasiben
Copy link
Member

quasiben commented Jun 1, 2021

rerun tests

As `libcucim` is just the C++ components and doesn't link to `python`,
this shouldn't need to be specified here. It's also causing
`conda-build` to raise some warnings.
Not specifying these may be leaving things underconstrained for the
solver. So try to constrain them a bit more.
Seems the solver was trying to mix incompatible `python` versions
before. This should correct that.
@jakirkham
Copy link
Member Author

Resolved in PR ( #51 )

@jakirkham jakirkham closed this Jun 9, 2021
@jakirkham jakirkham deleted the fixup_ci_2 branch June 9, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants