-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-up install issues encountered on CI #45
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
bug
Something isn't working
non-breaking
Introduces a non-breaking change
labels
May 27, 2021
gigony
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Do you know why it is still failing in CI/CD?
rerun tests |
As `libcucim` is just the C++ components and doesn't link to `python`, this shouldn't need to be specified here. It's also causing `conda-build` to raise some warnings.
Not specifying these may be leaving things underconstrained for the solver. So try to constrain them a bit more.
Seems the solver was trying to mix incompatible `python` versions before. This should correct that.
Merged
Resolved in PR ( #51 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes PR ( #41 ) and PR ( #43 )Dropped as these are now inbranch-21.06
Also makes some fixes to hopefully address the install issues we are seeing on CI.