Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace leftover templates in CODEOWNERS [skip ci] #7

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Replace leftover templates in CODEOWNERS [skip ci] #7

merged 3 commits into from
Apr 15, 2021

Conversation

jakirkham
Copy link
Member

jakirkham
jakirkham commented Apr 13, 2021
View reviewed changes
Copy link
Member Author

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple questions about adding people to teams below

.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@jakirkham jakirkham added non-breaking Introduces a non-breaking change bug Something isn't working labels Apr 13, 2021
@ajschmidt8 ajschmidt8 changed the title Replace leftover templates in CODEOWNERS Replace leftover templates in CODEOWNERS [skip ci] Apr 13, 2021
ajschmidt8
ajschmidt8 approved these changes Apr 13, 2021
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@jakirkham jakirkham requested a review from quasiben April 13, 2021 21:27
@jakirkham
Copy link
Member Author

Thanks AJ! 😄

@jakirkham @gigony
Include pybind11 under C++ code owners
8b332cc 
Co-authored-by: Gigon Bae <gigony@gmail.com>
@jakirkham jakirkham requested a review from gigony April 14, 2021 02:28
gigony
gigony approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the good practices on this file (I need to learn more about that) but looks good to me.

@jakirkham
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0422230 into rapidsai:branch-0.20 Apr 15, 2021
@jakirkham jakirkham deleted the fix_codeowners branch April 15, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigony gigony gigony approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@quasiben quasiben Awaiting requested review from quasiben

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @quasiben @gigony @ajschmidt8