Ensure include headers are marked with CUDF_EXPORT

cpp/include/cudf/detail/datetime.hpp

@@ -23,7 +23,7 @@
 
 #include <memory>
 
-namespace cudf {
+namespace CUDF_EXPORT cudf {
 namespace datetime {
 namespace detail {
 /**
@@ -174,4 +174,4 @@ std::unique_ptr<cudf::column> extract_quarter(cudf::column_view const& column,
 
 }  // namespace detail
 }  // namespace datetime
-}  // namespace cudf
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/detail/groupby.hpp

@@ -25,10 +25,8 @@
 #include <memory>
 #include <utility>
 
-namespace cudf {
-namespace groupby {
-namespace detail {
-namespace hash {
+namespace CUDF_EXPORT cudf {
+namespace groupby::detail::hash {
 /**
  * @brief Indicates if a set of aggregation requests can be satisfied with a
  * hash-based groupby implementation.
@@ -47,8 +45,5 @@ std::pair<std::unique_ptr<table>, std::vector<aggregation_result>> groupby(
   null_policy include_null_keys,
   rmm::cuda_stream_view stream,
   rmm::device_async_resource_ref mr);
-}  // namespace hash
-
-}  // namespace detail
-}  // namespace groupby
-}  // namespace cudf
+}  // namespace groupby::detail::hash
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/detail/groupby/group_replace_nulls.hpp

@@ -24,7 +24,7 @@
 
 #include <rmm/exec_policy.hpp>
 #include <rmm/resource_ref.hpp>
-namespace cudf {
+namespace CUDF_EXPORT cudf {
 namespace groupby {
 namespace detail {
 
@@ -45,4 +45,4 @@ std::unique_ptr<column> group_replace_nulls(cudf::column_view const& grouped_val
 
 }  // namespace detail
 }  // namespace groupby
-}  // namespace cudf
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/detail/groupby/sort_helper.hpp

@@ -25,10 +25,8 @@
 #include <rmm/device_uvector.hpp>
 #include <rmm/resource_ref.hpp>
 
-namespace cudf {
-namespace groupby {
-namespace detail {
-namespace sort {
+namespace CUDF_EXPORT cudf {
+namespace groupby::detail::sort {
 /**
  * @brief Helper class for computing sort-based groupby
  *
@@ -229,7 +227,5 @@ struct sort_groupby_helper {
   std::vector<null_order> _null_precedence;  ///< How to sort NULLs
 };
 
-}  // namespace sort
-}  // namespace detail
-}  // namespace groupby
-}  // namespace cudf
+}  // namespace groupby::detail::sort
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/detail/tdigest/tdigest.hpp

@@ -24,9 +24,8 @@
 #include <rmm/cuda_stream_view.hpp>
 #include <rmm/resource_ref.hpp>
 
-namespace cudf {
-namespace tdigest {
-namespace detail {
+namespace CUDF_EXPORT cudf {
+namespace tdigest::detail {
 
 /**
  * @brief Generate a tdigest column from a grouped, sorted set of numeric input values.
@@ -238,6 +237,5 @@ std::unique_ptr<scalar> reduce_merge_tdigest(column_view const& input,
                                              rmm::cuda_stream_view stream,
                                              rmm::device_async_resource_ref mr);
 
-}  // namespace detail
-}  // namespace tdigest
-}  // namespace cudf
+}  // namespace tdigest::detail
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/io/text/detail/bgzip_utils.hpp

@@ -27,7 +27,7 @@
 #include <fstream>
 #include <limits>
 
-namespace cudf {
+namespace CUDF_EXPORT cudf {
 namespace io::text::detail::bgzip {
 
 struct header {
@@ -91,7 +91,6 @@ void write_footer(std::ostream& output_stream, host_span<char const> data);
  *                           BGZIP block size subfield
  * @param post_size_subfields Any subfields to be placed after the BGZIP block size subfield
  */
-CUDF_EXPORT
 void write_uncompressed_block(std::ostream& output_stream,
                               host_span<char const> data,
                               host_span<char const> pre_size_subfields  = {},
@@ -107,11 +106,10 @@ void write_uncompressed_block(std::ostream& output_stream,
  *                           BGZIP block size subfield
  * @param post_size_subfields Any subfields to be placed after the BGZIP block size subfield
  */
-CUDF_EXPORT
 void write_compressed_block(std::ostream& output_stream,
                             host_span<char const> data,
                             host_span<char const> pre_size_subfields  = {},
                             host_span<char const> post_size_subfields = {});
 
 }  // namespace io::text::detail::bgzip
-}  // namespace cudf
+}  // namespace CUDF_EXPORT cudf

cpp/include/cudf/strings/detail/merge.hpp

@@ -18,10 +18,12 @@
 #include <cudf/column/column.hpp>
 #include <cudf/detail/merge.hpp>
 #include <cudf/strings/strings_column_view.hpp>
+#include <cudf/utilities/export.hpp>
 
 #include <rmm/cuda_stream_view.hpp>
 
-namespace cudf::strings::detail {
+namespace CUDF_EXPORT cudf {
+namespace strings::detail {
 /**
  * @brief Merges two strings columns
  *
@@ -38,4 +40,5 @@ std::unique_ptr<column> merge(strings_column_view const& lhs,
                               rmm::cuda_stream_view stream,
                               rmm::device_async_resource_ref mr);
 
-}  // namespace cudf::strings::detail
+}  // namespace strings::detail
+}  // namespace CUDF_EXPORT cudf