Fix strings handling of hex in regex pattern #10220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
removed
the
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10220 +/- ##
================================================
+ Coverage 10.42% 10.45% +0.03%
================================================
Files 119 122 +3
Lines 20603 20527 -76
================================================
- Hits 2148 2147 -1
+ Misses 18455 18380 -75
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Feb 4, 2022
vyasr
approved these changes
Feb 7, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10213
Fixes parsing logic for
\xhex characters specified in a regex pattern.This also adds a gtest checking for all 127 possible matchable hex characters.