[Java] Added JNI for getMapValueForKeys #11104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razajafri
added
feature request
|
Seems need to format C++ code. refer to https://github.com/rapidsai/cudf/blob/branch-22.04/CONTRIBUTING.md#pre-commit-hooks |
revans2
approved these changes
Jun 14, 2022
| * @param keys the column view with keys to lookup in the column | ||
| * @return a column of values or nulls based on the lookup result | ||
| */ | ||
| public final ColumnVector getMapValueForKeys(ColumnView keys) { |
There was a problem hiding this comment.
Why not just call it getMapValue just like the Scalar API is called? If they do the same thing, then to me it is ideal to call them the same thing.
|
rerun tests |
revans2
approved these changes
Jun 14, 2022
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11104 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22844
Branches ? 0
===============================================
Hits ? 19715
Misses ? 3129
Partials ? 0 Continue to review full report at Codecov.
|
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Java method for getting values for a list of keys
fixes #10818