Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdb pretty-printers for simple types #11499

Merged
merged 9 commits into from
Sep 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,11 @@ if(CUDF_BUILD_BENCHMARKS)
add_subdirectory(benchmarks)
endif()

# build pretty-printer load script
if(Thrust_SOURCE_DIR AND rmm_SOURCE_DIR)
configure_file(scripts/load-pretty-printers.in load-pretty-printers @ONLY)
endif()

# ##################################################################################################
# * install targets -------------------------------------------------------------------------------
rapids_cmake_install_lib_dir(lib_dir)
Expand Down
84 changes: 84 additions & 0 deletions cpp/scripts/gdb-pretty-printers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
# Copyright (c) 2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

import gdb

global_locals = locals()
if not all(
name in global_locals
for name in (
"HostIterator",
"DeviceIterator",
"is_template_type_not_alias",
"template_match",
)
):
raise NameError(
"This file expects the RMM pretty-printers to be loaded already. "
"Either load them manually, or use the generated load-pretty-printers "
"script in the build directory"
)


class CudfHostSpanPrinter(gdb.printing.PrettyPrinter):
"""Print a cudf::host_span"""

def __init__(self, val):
self.val = val
self.pointer = val["_data"]
self.size = int(val["_size"])

def children(self):
return HostIterator(self.pointer, self.size)

def to_string(self):
return f"{self.val.type} of length {self.size} at {hex(self.pointer)}"

def display_hint(self):
return "array"


class CudfDeviceSpanPrinter(gdb.printing.PrettyPrinter):
"""Print a cudf::device_span"""

def __init__(self, val):
self.val = val
self.pointer = val["_data"]
self.size = int(val["_size"])

def children(self):
return DeviceIterator(self.pointer, self.size)

def to_string(self):
return f"{self.val.type} of length {self.size} at {hex(self.pointer)}"

def display_hint(self):
return "array"


def lookup_cudf_type(val):
if not str(val.type.unqualified()).startswith("cudf::"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this printer work if we use using namespace cudf ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, using is a source-level alias that doesn't affect the generated debug info, afaik.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that's the case after some small experiments :)

return None
suffix = str(val.type.unqualified())[6:]
if not is_template_type_not_alias(suffix):
return None
if template_match(suffix, "host_span"):
return CudfHostSpanPrinter(val)
if template_match(suffix, "device_span"):
return CudfDeviceSpanPrinter(val)
return None


gdb.pretty_printers.append(lookup_cudf_type)
3 changes: 3 additions & 0 deletions cpp/scripts/load-pretty-printers.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source @Thrust_SOURCE_DIR@/scripts/gdb-pretty-printers.py
source @rmm_SOURCE_DIR@/scripts/gdb-pretty-printers.py
source @PROJECT_SOURCE_DIR@/scripts/gdb-pretty-printers.py