[REVIEW] Fix issue with nvstrings dependency in branch-0.6 #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
requested changes
Mar 20, 2019
kkraus14
reviewed
Mar 20, 2019
kkraus14
reviewed
Mar 20, 2019
kkraus14
reviewed
Mar 20, 2019
|
That was a lot more commentary than I expected! Your suggested changes are all in. |
harrism
requested changes
Mar 20, 2019
harrism
approved these changes
Mar 21, 2019
kkraus14
approved these changes
Mar 21, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1231 and also fixes #1251.
Update the README with instructions on creating a new conda environment either for CUDA 9.2 or CUDA 10.0. This should resolve issues that users are having with incorrect NVStrings dependencies, which by default was installing NVStrings=0.2.0 for CUDA 9.2.