Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::thread_index_type in replace.cu. #13905

Merged
merged 6 commits into from
Sep 2, 2023
Merged

Use cudf::thread_index_type in replace.cu. #13905

merged 6 commits into from
Sep 2, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 17, 2023 •
edited
Loading

Description

This PR uses cudf::thread_index_type in replace.cu to avoid risk of overflow.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner August 17, 2023 20:45
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 17, 2023
@bdice bdice self-assigned this Aug 17, 2023
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 17, 2023
PointKernel
PointKernel approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
vuule
vuule reviewed Aug 18, 2023
View reviewed changes
cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
@GregoryKimball GregoryKimball mentioned this pull request Aug 21, 2023
Open
@bdice bdice requested review from vuule and davidwendt August 24, 2023 21:44
ttnghia
ttnghia reviewed Aug 26, 2023
View reviewed changes
cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed Aug 26, 2023
View reviewed changes
cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed Aug 26, 2023
View reviewed changes
cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed Aug 26, 2023
View reviewed changes
cpp/src/replace/replace.cu Outdated Show resolved Hide resolved
@bdice bdice requested a review from ttnghia September 1, 2023 21:33
@bdice
Copy link
Contributor Author

bdice commented Sep 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0c829cc into rapidsai:branch-23.10 Sep 2, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@vuule vuule vuule approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt

Assignees

@bdice bdice

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @ttnghia @PointKernel @vuule @davidwendt