[Java] Choose The Correct RoundingMode For Checking Decimal OutOfBounds #14731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com> Added tests
razajafri
force-pushed
the
fixed-decimal-bounds
branch
from
20c6862
to
160a3c5
Compare
|
/ok to test |
ttnghia
reviewed
Jan 10, 2024
|
/ok to test |
ttnghia
reviewed
Jan 10, 2024
Comment on lines
91
to
92
| // In ex:1 If we rounded down the rhs 100.19 would become 100.1, and now 100.1 is not < 100.1 | ||
| // In ex:2 If we rounded up the rhs -100.19 would become -100.2, and now -100.2 is not < -100.2 |
There was a problem hiding this comment.
So what are the correct rounding for these examples? I'm confused. Please be explicit.
ttnghia
reviewed
Jan 10, 2024
Comment on lines
147
to
156
|
|
||
| // First we have to round the scalar (rhs) to the same scale as lhs. | ||
| // Because this is a greater-than, and it is rhs that we are rounding, we will round towards 0 (DOWN) in case rhs is | ||
| // positive and away from 0 (UP) if rhs is negative to make sure we always return the correct value. | ||
| // For example: | ||
| // ex:1 100.2 > 100.19 | ||
| // ex:2 -100.1 > -100.19 | ||
| // In ex:1 If we rounded up the rhs 100.19 would become 100.2, and now 100.2 is not > 100.2 | ||
| // In ex:2 If we rounded down the rhs -100.19 would become -100.1, and now -100.1 is not > -100.1 | ||
| BigDecimal roundedRhs = rhs.setScale(-cvScale, rhs.signum() > 0 ? BigDecimal.ROUND_DOWN : BigDecimal.ROUND_UP); |
There was a problem hiding this comment.
This is just repeated of the code above. We should not copy-paste code around. If there is the same code used multiple times, let's extract it into a function and call it multiple times instead.
jlowe
reviewed
Jan 10, 2024
jlowe
reviewed
Jan 10, 2024
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
/ok to test |
jlowe
approved these changes
Jan 10, 2024
|
/ok to test |
revans2
approved these changes
Jan 11, 2024
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error in the
outOfBoundsmethod in which theRoundingModewas selected based on positive values only. The RHS should be rounded towards positive infinity (ROUND_CEILING) for the lower bound and towards negative infinity (ROUND_FLOOR) for the upper boundcloses #14732
Checklist