Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rolling in pylibcudf #14982

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 6, 2024

Description

Contributes to #13921

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request non-breaking Non-breaking change labels Feb 6, 2024
@vyasr vyasr self-assigned this Feb 6, 2024
@vyasr vyasr requested a review from a team as a code owner February 6, 2024 23:58
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Feb 6, 2024
@classmethod
def from_udf(cls, op, *args, **kwargs):
# Handling UDF type
nb_type = numpy_support.from_dtype(kwargs['dtype'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Would be since if dtype was explicitly in the signature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. There's a lot of rewriting of the Cython layer that we should do once pylibcudf is completed.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 8, 2024

/merge

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Feb 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit b2164c2 into rapidsai:branch-24.04 Feb 8, 2024
69 checks passed
@vyasr vyasr deleted the feat/pylibcudf_rolling branch February 8, 2024 17:05
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants