Implement replace in pylibcudf #15005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
bdice
approved these changes
Feb 8, 2024
| Column source_column, | ||
| Scalar lo, | ||
| Scalar hi, | ||
| Scalar lo_replace=*, |
There was a problem hiding this comment.
What does this =* syntax mean? This doesn't seem like anything I've seen in Python, C++, or Cython before.
There was a problem hiding this comment.
This is the standard Cython syntax for default arguments in pxd files. The actual default value must be specified in the implementation (the pyx file) while the declaration just indicates that a default exists so that callers know what valid invocations look like. We have this in a couple of places in our existing Cython like column.pxd and scalar.pxd
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #13921
Checklist