Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use variable substitution for RAPIDS version in Doxyfile #15231

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Use variable substitution for RAPIDS version in Doxyfile #15231

merged 4 commits into from
Mar 8, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Mar 5, 2024 •
edited by bdice
Loading

Description

Doxyfiles support environment variable substitution, so read the version from VERSION and put it in an environment variable.

Also remove a hard-coded version from ci/check_style.sh.

Issue: rapidsai/build-planning#15

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 5, 2024 18:09
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue ci labels Mar 5, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 5, 2024
bdice
bdice reviewed Mar 5, 2024
View reviewed changes
ci/check_style.sh Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks Kyle! 🙏

Think we can also make these changes: rapidsai/build-planning#15 (comment) + rapidsai/build-planning#15 (comment)

harrism
harrism reviewed Mar 6, 2024
View reviewed changes
ci/build_docs.sh Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

@jakirkham It seems cudf is already using that approach:

cudf/python/cudf/pyproject.toml

Line 18 in bb0e4fd

dynamic = ["version"]

@KyleFromNVIDIA KyleFromNVIDIA added 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Mar 6, 2024
@bdice
Copy link
Contributor

bdice commented Mar 7, 2024

@KyleFromNVIDIA Looks great - this should be ready to merge with an ops review.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7b0eee1 into rapidsai:branch-24.04 Mar 8, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism left review comments

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
4 - Needs Review Waiting for reviewer to review or respond CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @jakirkham @bdice @harrism @AyodeAwe