Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port start of datetime.hpp to pylibcudf #15916

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Port start of datetime.hpp to pylibcudf #15916

merged 4 commits into from
Jun 13, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 4, 2024

Description

Start exposing datetime extraction functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner June 4, 2024 16:44
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Jun 4, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Python Affects Python cuDF API. CMake CMake build issue labels Jun 4, 2024
charlesbluca
charlesbluca reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also get an added API doc linked in the index such as this?

python/cudf/cudf/_lib/pylibcudf/libcudf/CMakeLists.txt Show resolved Hide resolved
@wence-
Copy link
Contributor Author

wence- commented Jun 5, 2024

Should this also get an added API doc linked in the index such as this?

* https://github.com/rapidsai/cudf/blob/branch-24.08/docs/cudf/source/user_guide/api_docs/pylibcudf/aggregation.rst

Should this also get an added API doc linked in the index such as this?

* https://github.com/rapidsai/cudf/blob/branch-24.08/docs/cudf/source/user_guide/api_docs/pylibcudf/aggregation.rst

Yes, thanks! Done.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Jun 5, 2024
vyasr
vyasr approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM.

python/cudf/cudf/pylibcudf_tests/test_datetime.py Outdated Show resolved Hide resolved
@wence- wence- force-pushed the wence/fea/pylibcudf-datetime branch from c6cd564 to 354a2fd Compare June 13, 2024 11:21
@wence-
Copy link
Contributor Author

wence- commented Jun 13, 2024

/merge

@rapids-bot rapids-bot bot merged commit f651f12 into rapidsai:branch-24.08 Jun 13, 2024
75 checks passed
@wence- wence- deleted the wence/fea/pylibcudf-datetime branch June 13, 2024 15:44
@lithomas1 lithomas1 mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@charlesbluca charlesbluca charlesbluca left review comments

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @vyasr @charlesbluca