Add test coverage for slicing with "out of bounds" negative indices #15990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we might want to avoid running certain optimization passes, so enable that in the testing assertion function.
Polars wraps negative starts and then clamps both the resulting start and length to [0, num_rows), so we should do that. Add tests of this behaviour as well.
github-actions
bot
added
Python
|
Before: After: |
wence-
added
improvement
bdice
approved these changes
Jun 12, 2024
| ) | ||
| def test_slice(offset, len): | ||
| @pytest.mark.parametrize("slice_pushdown", [False, True]) | ||
| def test_slice(offset, len, slice_pushdown): |
There was a problem hiding this comment.
Avoid shadowing the Python built-in len. I would rename this parameter to length to match the Polars API: https://docs.pola.rs/api/python/stable/reference/dataframe/api/polars.DataFrame.slice.html
|
/merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polars wraps negative starts and then clamps both the resulting start
and length to [0, num_rows), so we should do that.
Add tests of this behaviour as well.
Checklist