Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage of binops where one or both operands are a scalar #15998

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Coverage of binops where one or both operands are a scalar #15998

merged 1 commit into from
Jun 18, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

Just needed the tests here.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested a review from a team as a code owner June 12, 2024 14:00
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
@wence- wence- changed the title Coverage of binops where one or both operand is a scalar Coverage of binops where one or both operands are a scalar Jun 12, 2024
@wence- wence- mentioned this pull request Jun 12, 2024
Closed
3 tasks
@vyasr
Copy link
Contributor

vyasr commented Jun 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9bc794a into rapidsai:branch-24.08 Jun 18, 2024
80 checks passed
@wence- wence- deleted the wence/fea/test-binop-scalars branch June 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wence- @vyasr