Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings batch construction #16727

Draft
wants to merge 12 commits into
base: branch-24.10
Choose a base branch
from
Draft

Strings batch construction #16727

wants to merge 12 commits into from
+365 −11

Conversation

sdrp713
Copy link
Contributor

@sdrp713 sdrp713 commented Sep 3, 2024

Description

Combines iterative allocation of string columns into one batch function which reduces stream synchronization.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

ttnghia and others added 9 commits August 2, 2024 16:27
@ttnghia
Implement valid_if_async
5549de6 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Change docs
8b169f5 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Use atomic_ref
55a56b7 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Add make_strings_column benchmark
0928218 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Implement strings_column_batch_construction benchmark
6705012 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Rename functions
df42074 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Add empty function
d5770a4 
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Revert changes in valid_if.cuh
4b94981
@sdrp713
Draft of Code
a584a34
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Sep 3, 2024
ttnghia
ttnghia requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flush my first round of comments. There are still many issues that need to be addressed.

cpp/include/cudf/detail/sizes_to_offsets_iterator.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/sizes_to_offsets_iterator.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/valid_if.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/valid_if.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/detail/valid_if.cuh Outdated Show resolved Hide resolved
cpp/src/strings/strings_column_factories.cu Outdated Show resolved Hide resolved
cpp/src/strings/strings_column_factories.cu Outdated Show resolved Hide resolved
cpp/src/strings/strings_column_factories.cu Show resolved Hide resolved
cpp/src/strings/strings_column_factories.cu Outdated Show resolved Hide resolved
cpp/include/cudf/strings/detail/strings_children.cuh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia requested changes

Assignees
No one assigned
Labels
CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrp713 @ttnghia