Add string.find_multiple APIs to pylibcudf #16920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
github-actions
bot
added
Python
vyasr
approved these changes
Sep 27, 2024
| ) | ||
| ] | ||
| ) | ||
| assert result.equals(expected) |
There was a problem hiding this comment.
No need to change it in this PR, but in general you don't need to create the chunked array from a normal array manually. If you use the assert_column_eq and similar functions from our utils it will handle that for you (or at least it should; if there are cases that aren't handled we should address that). We should toss those kinds of conversions where we don't actually care about the differences into that function so that we don't have to think about it when writing tests.
…trings/find_multiple
…trings/find_multiple
Matt711
approved these changes
Oct 1, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redo at #16824
Contributes to #15162
Checklist