Add string.split APIs to pylibcudf #16940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
github-actions
bot
added
Python
| from cython.operator import dereference | ||
|
|
||
|
|
||
| cpdef Table partition(Column input, Scalar delimiter): |
There was a problem hiding this comment.
Can we add the empty string default value here? We've done it like this so far.
There was a problem hiding this comment.
Ah OK. I think I may have missed this default value pattern to match the libcudf default value in my recently pylibcudf PRs. I'll got back in a follow up to try to address this.
| return pa_array, plc_column | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
We might consider parameterizing over None here as the delimiter as well once the APIs handle the default value
brandon-b-miller
approved these changes
Sep 30, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Includes
split/split.pxdandsplit/partition.pxdChecklist