Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Migrate nvtext/edit_distance APIs to pylibcudf #16957

Merged
merged 3 commits into from
Oct 4, 2024
Merged

[FEA] Migrate nvtext/edit_distance APIs to pylibcudf #16957

merged 3 commits into from
Oct 4, 2024
+171 −25

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 30, 2024

Description

Apart of #15162. This PR migrates edit_distance.pxd to pylibcudf

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Sep 30, 2024
@Matt711 Matt711 self-assigned this Sep 30, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Sep 30, 2024
@Matt711 Matt711 changed the title [WIP] Migrate nvtext/edit_distance APIs to pylibcudf [FEA] Migrate nvtext/edit_distance APIs to pylibcudf Oct 1, 2024
@Matt711 Matt711 marked this pull request as ready for review October 1, 2024 23:55
@Matt711 Matt711 requested review from a team as code owners October 1, 2024 23:55
@Matt711 Matt711 mentioned this pull request Oct 2, 2024
Open
mroeschke
mroeschke reviewed Oct 3, 2024
View reviewed changes
python/pylibcudf/pylibcudf/__init__.pxd
@@ -78,4 +79,5 @@ __all__ = [
"transpose",
"types",
"unary",
"nvtext",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you keep list alphabetical as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, will follow up

mroeschke
mroeschke reviewed Oct 3, 2024
View reviewed changes
python/pylibcudf/pylibcudf/__init__.py
@@ -92,4 +93,5 @@
"transpose",
"types",
"unary",
"nvtext",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you keep list alphabetical as well?

mroeschke
mroeschke approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications can be done in a follow up, but LGTM

davidwendt
davidwendt approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ approval

@Matt711
Copy link
Contributor Author

Matt711 commented Oct 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit 04c17de into rapidsai:branch-24.12 Oct 4, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@PointKernel PointKernel PointKernel approved these changes

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@Matt711 Matt711

Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt711 @mroeschke @PointKernel @davidwendt