Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove unnecessary std::move's in pylibcudf #16983

Draft
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from
Draft

[WIP] Remove unnecessary std::move's in pylibcudf #16983

wants to merge 3 commits into from
+30 −31

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 2, 2024

Description

DO NOT MERGE. I wanted to check whether we can remove a lot of unecessary std::move's from pylibcudf

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 2, 2024
@Matt711 Matt711 self-assigned this Oct 2, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@Matt711 Matt711 changed the title [WIP] Remove unnecessary move's in pylibcudf [WIP] Remove unnecessary `mcoccccbrfutcbvcdcldtctuknvcuhrdbrhiendivbdcdene's in pylibcudf Oct 2, 2024
@Matt711 Matt711 changed the title [WIP] Remove unnecessary `mcoccccbrfutcbvcdcldtctuknvcuhrdbrhiendivbdcdene's in pylibcudf [WIP] Remove unnecessary std::move's in pylibcudf Oct 2, 2024
Matt711
Matt711 commented Oct 2, 2024
View reviewed changes
python/pylibcudf/pylibcudf/strings/convert/CMakeLists.txt
@@ -15,8 +15,13 @@
set(cython_sources convert_durations.pyx convert_datetime.pyx)

set(linked_libraries cudf::cudf)

# Set the Cython flags to include annotation
set(CYTHON_FLAGS "--annotate")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Delete this

@Matt711 Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Matt711 Matt711

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
pylibcudf
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Matt711