Add string.convert.convert_ipv4 APIs to pylibcudf #16994
+151
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
vyasr
approved these changes
Oct 4, 2024
| Parameters | ||
| ---------- | ||
| integers : Column | ||
| Integer (uint32) column to convert. |
There was a problem hiding this comment.
This isays uint32 whereas ipv4_to_integers above says it produces int32. Should these be the same, or is one really unsigned while the other is signed?
There was a problem hiding this comment.
Thanks, this was a documentation mistake on my end. ipv4_to_integers should say it returns uint32 integers (matching the cpp docstring and the unit test in this PR)
There was a problem hiding this comment.
OK cool yes please match those when you resolve conflicts, then you are good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Checklist