Fix cuDF benchmarks build with static Arrow lib and fix rapids-compose cuDF JNI build [skip-ci] #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
libcudf
jlowe
approved these changes
Nov 11, 2020
kkraus14
pushed a commit
that referenced
this pull request
Nov 13, 2020
Converting libcudf to use `rmm::cuda_stream_view` will require a LOT of changes, so I'm splitting it into multiple PRs to ease reviewing. This is the first PR in the series. This series of PRs will - Replace usage of `cudaStream_t` with `rmm::cuda_stream_view` - Replace usage of `0` or `nullptr` as a stream identifier with `rmm::cuda_stream_default` - Ensure all APIs always order the stream parameter *before* the memory resource parameter. #5119 This first PR converts: - column.hpp (and source) - device_column_view.cuh - copying.hpp (and source) : moves functions that had streams in public APIs to `namespace detail` and adds streamless public versions. - null_mask.hpp (and source) : moves functions that had streams in public APIs to `namespace detail` and adds streamless public versions. - AST (transform) - Usages of the above APIs in other source files - Some benchmarks Contributes to #6645 and #5119 ~Depends on #6732.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmakelists for cuDF benchmarks (which are not built by default) failed to compile when
ARROW_STATIC_LIB was enabled. This fixes that failure.
Also adds a cmake variable passthrough to the cuDF JNI pom.xml to enable building
cuDF JNI bindings when the cuDF build directory is not the default of cudf/cpp/build,
as is common when using rapids-compose to build from source.